infra[notask]: rename desktop test runner labels for sdk tests-qvac#1922
Merged
Conversation
Update the GPU runner labels used by the SDK desktop tests workflows to the new naming scheme: - ai-run-windows11-gpu -> qvac-win25-x64-gpu - ai-run-linux-gpu -> qvac-ubuntu2204-x64-gpu - mac-mini-m4-gpu (unchanged) Affected: - .github/workflows/test-sdk.yml: update default for desktop-platforms in workflow_dispatch and workflow_call inputs, plus the inline fallback used when calling test-desktop-sdk.yml. - .github/workflows/test-desktop-sdk.yml: refresh the runner-label example in the platforms input description for consistency. Co-authored-by: Cursor <cursoragent@cursor.com>
opaninakuffo
previously approved these changes
May 6, 2026
NamelsKing
previously approved these changes
May 6, 2026
NamelsKing
previously approved these changes
May 8, 2026
tamer-hassan-tether
approved these changes
May 8, 2026
lauripiisang
approved these changes
May 8, 2026
opaninakuffo
approved these changes
May 8, 2026
NamelsKing
approved these changes
May 9, 2026
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: be concise and prefer bullet points.
🎯 What problem does this PR solve?
qvac-*); the old labels (ai-run-windows11-gpu,ai-run-linux-gpu) no longer match any available runner.tests-qvacdesktop jobs would queue indefinitely / fail to schedule on Windows and Linux.📝 How does it solve it?
packages/sdk/tests-qvacworkflows:ai-run-windows11-gpu→qvac-win25-x64-gpuai-run-linux-gpu→qvac-ubuntu2204-x64-gpumac-mini-m4-gpuunchanged.github/workflows/test-sdk.yml: replace defaults in bothworkflow_dispatch.inputs.desktop-platformsandworkflow_call.inputs.desktop-platforms, and the inline fallback for thedesktop-testsjob that callstest-desktop-sdk.yml..github/workflows/test-desktop-sdk.yml: refresh the example in theplatformsinput description so it matches the new naming.🧪 How was it tested?
ai-run-windows11-gpuorai-run-linux-gpuremain insidepackages/sdk/**,.github/workflows/test-sdk.yml, or.github/workflows/test-desktop-sdk.yml.tests-qvacworkflow run from this branch / a follow-up dispatch.