Skip to content

infra[notask]: rename desktop test runner labels for sdk tests-qvac#1922

Merged
Victor-Rodzko merged 4 commits into
mainfrom
infra/sdk-rename-test-runners
May 11, 2026
Merged

infra[notask]: rename desktop test runner labels for sdk tests-qvac#1922
Victor-Rodzko merged 4 commits into
mainfrom
infra/sdk-rename-test-runners

Conversation

@Victor-Rodzko

Copy link
Copy Markdown
Contributor

Note: be concise and prefer bullet points.

🎯 What problem does this PR solve?

  • Self-hosted GPU runners for SDK desktop tests have been renamed to a new naming scheme (qvac-*); the old labels (ai-run-windows11-gpu, ai-run-linux-gpu) no longer match any available runner.
  • Without this update, SDK tests-qvac desktop jobs would queue indefinitely / fail to schedule on Windows and Linux.

📝 How does it solve it?

  • Update default desktop runner labels used by packages/sdk/tests-qvac workflows:
    • ai-run-windows11-gpuqvac-win25-x64-gpu
    • ai-run-linux-gpuqvac-ubuntu2204-x64-gpu
    • mac-mini-m4-gpu unchanged
  • .github/workflows/test-sdk.yml: replace defaults in both workflow_dispatch.inputs.desktop-platforms and workflow_call.inputs.desktop-platforms, and the inline fallback for the desktop-tests job that calls test-desktop-sdk.yml.
  • .github/workflows/test-desktop-sdk.yml: refresh the example in the platforms input description so it matches the new naming.

🧪 How was it tested?

  • Verified via repo-wide search that no occurrences of ai-run-windows11-gpu or ai-run-linux-gpu remain inside packages/sdk/**, .github/workflows/test-sdk.yml, or .github/workflows/test-desktop-sdk.yml.
  • Other workflow files (non-SDK addons, C++ tests, benchmarks) are intentionally left untouched and are out of scope for this PR.
  • End-to-end runner scheduling will be exercised on the next SDK tests-qvac workflow run from this branch / a follow-up dispatch.

Update the GPU runner labels used by the SDK desktop tests workflows to
the new naming scheme:

- ai-run-windows11-gpu  -> qvac-win25-x64-gpu
- ai-run-linux-gpu      -> qvac-ubuntu2204-x64-gpu
- mac-mini-m4-gpu       (unchanged)

Affected:

- .github/workflows/test-sdk.yml: update default for desktop-platforms
  in workflow_dispatch and workflow_call inputs, plus the inline
  fallback used when calling test-desktop-sdk.yml.
- .github/workflows/test-desktop-sdk.yml: refresh the runner-label
  example in the platforms input description for consistency.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Victor-Rodzko Victor-Rodzko requested a review from a team as a code owner May 6, 2026 13:55
opaninakuffo
opaninakuffo previously approved these changes May 6, 2026
NamelsKing
NamelsKing previously approved these changes May 6, 2026
NamelsKing
NamelsKing previously approved these changes May 8, 2026
@Victor-Rodzko

Copy link
Copy Markdown
Contributor Author

/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants